Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

dot-prop cannot be updated #3654

Closed
1 task
andrewscfc opened this issue Aug 4, 2020 · 1 comment · Fixed by #3689
Closed
1 task

dot-prop cannot be updated #3654

andrewscfc opened this issue Aug 4, 2020 · 1 comment · Fixed by #3689
Assignees
@andrewscfc
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details cross-team For visibility for both World Service teams (Engage & Media) dependencies Pull requests that update a dependency file Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. security
Projects
Simorgh
Milestone
Dependency Updates

Comments

@andrewscfc
Copy link
Contributor

andrewscfc commented Aug 4, 2020 •
edited

Is your feature request related to a problem? Please describe.
We cannot currently update the dot-prop dependency due to lerna using an outdated version of dot-prop

https://github.com/bbc/psammead/network/alert/package-lock.json/dot-prop/open

Describe the solution you'd like
Update lerna when this PR goes into the project and a new release is made for lerna: lerna/lerna#2680

Describe alternatives you've considered

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@andrewscfc andrewscfc added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. cross-team For visibility for both World Service teams (Engage & Media) labels Aug 4, 2020
@andrewscfc andrewscfc self-assigned this Aug 4, 2020
@andrewscfc andrewscfc added this to Issue in Progress in Simorgh Aug 4, 2020
@andrewscfc andrewscfc added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 4, 2020
@andrewscfc
Copy link
Contributor Author

image

@andrewscfc andrewscfc moved this from Issue in Progress to Blocked in Simorgh Aug 4, 2020
@andrewscfc andrewscfc added this to the Dependency Updates milestone Aug 17, 2020
@simonsinclair simonsinclair added the dependencies Pull requests that update a dependency file label Aug 18, 2020
@jroebu14 jroebu14 mentioned this issue Aug 24, 2020
Merged
3 tasks
Simorgh automation moved this from Blocked to Done Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewscfc andrewscfc

Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details cross-team For visibility for both World Service teams (Engage & Media) dependencies Pull requests that update a dependency file Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. security
Projects
No open projects
Simorgh
Done
Milestone
Dependency Updates
Development

Successfully merging a pull request may close this issue.

force versions of dependencies to remove security vulnerabilities bbc/psammead
2 participants
@simonsinclair @andrewscfc