Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove take check from Style/UnpackFirst cop #5764

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

parkerfinch
Copy link
Contributor

Enumerable#take returns an Array, so the "bad" example
'foo'.unpack('h*').take(1) returns a single element Array while
the "good" example 'foo'.unpack1('h*') returns a String.

Removing take from the methods checked by this cop prevents erroneous messages/autocorrects.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Contributor

@bdewater bdewater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Thanks!

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 11, 2018

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

`Enumerable#take` returns an `Array`, so the "bad" example
`'foo'.unpack('h*').take(1)` returns a single element `Array` while
the "good" example `'foo'.unpack1('h*')` returns a `String`.
@bbatsov bbatsov merged commit ab008b0 into rubocop:master Apr 11, 2018
@parkerfinch
Copy link
Contributor Author

Thanks @bbatsov, rebased!

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 11, 2018

Thanks!

@parkerfinch parkerfinch deleted the rm-unpack-first-take branch April 11, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants