Fix Performance/RegexpMatch cop not correcting negated match operator
#5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
regexp-negated-match
branch
from
10df74b
to
29310f1
Compare
koic
reviewed
Apr 10, 2018
| @@ -329,6 +329,24 @@ def foo | |||
| 're =~ FOO', 'FOO.match?(re)') | |||
| it_behaves_like(:all_legacy_match_methods, 'matching by =~`', | |||
| 'FOO =~ re', 'FOO.match?(re)') | |||
| it_behaves_like(:all_legacy_match_methods, 'matching by !~`', | |||
| '/re/ !~ foo', '!/re/.match?(foo)') | |||
There was a problem hiding this comment.
Offense of Layout/AlignParameters cop has occurred because these indentations are not aligned.
it_behaves_like(:all_legacy_match_methods, 'matching by !~`',
- '/re/ !~ foo', '!/re/.match?(foo)')
+ '/re/ !~ foo', '!/re/.match?(foo)')https://travis-ci.org/bbatsov/rubocop/jobs/364429172#L605-L634
bdewater
force-pushed
the
regexp-negated-match
branch
from
29310f1
to
66b5ba2
Compare
rrosenblum
approved these changes
Apr 10, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While messing around and having Rubocop correcting it's own source I noticed
!~went undetected.Before submitting the PR make sure the following are checked:
master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.