Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String#delete_{prefix,suffix} to Lint/Void cop #5752

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Apr 6, 2018

These methods were added in Ruby 2.5: https://ruby-doc.org/core-2.5.0/String.html#method-i-delete_prefix


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

### Bug fixes

* [#5752](https://github.com/bbatsov/rubocop/pull/5752): Add `String#delete_{prefix,suffix}` to Lint/Void cop. ([@bdewater][])
Copy link
Member

@koic koic Apr 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be written in Changes section instead of Bug fixes section.

@bbatsov bbatsov merged commit 76c714c into rubocop:master Apr 11, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 11, 2018

Thanks!

@bdewater bdewater deleted the update-void-methods branch April 11, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants