Fix false positive for :class_name option in Rails/InverseOf cop
#5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is not in `ActiveRecord::Reflection::AssociationReflection::INVALID_AUTOMATIC_INVERSE_OPTIONS` The documentation explains what the class name option is used for: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations.rb#L1002-L1017
bdewater
force-pushed
the
fix-inverseof-classname
branch
from
b7c028a
to
58131b1
Compare
wata727
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #5045 (comment) this was introduced in #5297 as a footnote /cc @swrobel @wata727
This option is not in
ActiveRecord::Reflection::AssociationReflection::INVALID_AUTOMATIC_INVERSE_OPTIONSThe documentation explains what the class name option is used for:
https://github.com/rails/rails/blob/2baf1aaeb1e1385ad2bf20728f4bc8c24efc7245/activerecord/lib/active_record/associations.rb#L1002-L1017
master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.