Add spaces as EnforcedStyle to SpaceInsideParens.

[joshuapinter]

Fixes #5666.

Add config option for Style/SpaceInsideParens Cop to enforce spaces.

Simply supply EnforcedStyle: space in your rubocop.yml configuration and instead of enforcing no spaces inside parens, it will enforce spaces.

Even supports auto-correct!

Stylistic choice, to be sure, but one that can help alleviate cluttered code and parentheses hell.

Add documentation for EnforcedStyle: space option.

Add Layout/SpaceInsideParens to default.yml.

This defaults the EnforcedStyle to no_space and then lists the supported styles, including space.

Code formatting to match rubocop style.

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

[bbatsov]

Ping us when the build is green and this is ready for review.

[Drenmi]

You need to finish the checklist (add CHANGELOG entry and regenerate documentation) before I can review. 🙂

[joshuapinter]

Will do! Sorry, we started using it in our codebase and it's working great so this got pushed down the to-do pile. :)

[bbatsov]

@joshuapinter Fair enough. Let us know when you decide to pick up it up again.

[joshuapinter]

@bbatsov Will do. Should be next week after we catch up on a few things.

[joshuapinter]

Hey Guys,

I've added an entry to CHANGELOG and fixed a few issues but when I try and re-generate the docs, I'm hitting this error:

$ bundle exec rake generate_cops_documentation
rake aborted!
NoMethodError: undefined method `type' for 68576:Fixnum
/Users/joshuapinter/.rbenv/versions/2.2.0/bin/bundle:23:in `load'
/Users/joshuapinter/.rbenv/versions/2.2.0/bin/bundle:23:in `<main>'
Tasks: TOP => generate_cops_documentation => yard_for_generate_documentation
(See full trace by running task with --trace)

Any ideas?

Thanks.

[joshuapinter]

Figured out what the issue was.

I was running Ruby 2.2.0 in my rbenv.

Changing my local rbenv to use Ruby 2.5.0 fixed the issue.

I regenerated the docs, resolved conflicts and pushed.

Just waiting on tests to pass now.

Btw, I don't think I can squash my commits now that I've created this PR but I think you can do that on your side when you merge this in. Correct me if I'm wrong, though, and let me know how to do it.

Thanks!

[joshuapinter]

Boom! Checks passing. We should be good to go!

[bbatsov]

LGMT! 👍

[joshuapinter]

👍