Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show all offenses in the console for --auto-gen-config #5451

Closed
Ana06 opened this issue Jan 12, 2018 · 3 comments
Closed

Do not show all offenses in the console for --auto-gen-config #5451

Ana06 opened this issue Jan 12, 2018 · 3 comments

Comments

@Ana06
Copy link
Contributor

Ana06 commented Jan 12, 2018

When generating the rubocop_todo.yml file, I do not see the point on showing all the offenses in the console as I just want to exclude them and it is not that important what offenses there are. In projects with a lot of offenses (for example if you introduce Rubocop for the first time) it fulls the console with the offenses.

I would suggest to directly remove this, we could also add this in an option.

@asherkach
Copy link
Contributor

Happy to own implementing this feature. Does --skip-console-output seem like the right flag name?

@garettarrowood
Copy link
Contributor

I'm with @Ana06 on this. I think there should be a flag to enable output and change the default behavior to not output offenses anymore. Upgrading large codebases with output creates a lot of unwanted noise. So perhaps an --output-offenses or --with-offenses flag for --auto-gen-config.

@Ana06
Copy link
Contributor Author

Ana06 commented Jan 16, 2018

@garettarrowood

I'm with @Ana06 on this. I think there should be a flag to enable output and change the default behavior to not output offenses anymore. Upgrading large codebases with output creates a lot of unwanted noise. So perhaps an --output-offenses or --with-offenses flag for --auto-gen-config.

--output-offenses seems like a good name 👍

@asherkach

Happy to own implementing this feature.

will you send a PR then? 😉

drewpterry added a commit to drewpterry/rubocop that referenced this issue Apr 4, 2018
…ouput offenses.

This makes it so that --auto-gen-config will not output offenses to the console by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants