Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: @bazel/runfiles needs to handle repo mapping #3714

Open
jfirebaugh opened this issue Feb 2, 2024 · 5 comments
Open

[FR]: @bazel/runfiles needs to handle repo mapping #3714

jfirebaugh opened this issue Feb 2, 2024 · 5 comments

Comments

@jfirebaugh
Copy link
Contributor

What is the current behavior?

The @bazel/runfiles library fails to find runfiles specified with apparent repository names when Bzlmod is enabled.

Describe the feature

Equivalent to bazelbuild/rules_go#3347 / bazelbuild/rules_python#998.

@alexeagle
Copy link
Collaborator

@fmeum I know you visited a lot of languages in the ecosystem for the other runfiles fixes. I don't recall, did you have a look here as well?

@fmeum
Copy link
Contributor

fmeum commented Feb 4, 2024

The lookup procedure itself looks sound. It's really just the repo mapping logic that is missing.

My JS is pretty rusty, so I would prefer someone else to implement this, but I can review the PR. The Python library can serve as a reference here.

The challenging part would be determining the current repo. I don't know how one would get the path of the current source file in JS. Minification and bundling could be problematic in this context. Can source maps be consumed at runtime?

@alexeagle
Copy link
Collaborator

@ewhauser is this something you're interested in pairing with Fabian on?

Copy link

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs in 30 days. Note as of rules_nodejs v6 the rules_nodejs repository contains only the core nodejs toolchain and @bazel/runfiles package. All rulesets are removed and unmaintained. For alternate rulesets suggestions include https://github.com/aspect-build/rules_js, https://github.com/aspect-build/rules_ts Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Apr 6, 2024
@jfirebaugh
Copy link
Contributor Author

Can someone please add a label to turn off the stale bot for this issue? This blocks use of bzlmod for anyone using @bazel/runfiles so it's not going to go stale.

@github-actions github-actions bot removed the Can Close? We will close this in 30 days if there is no further activity label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants