You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes, loads and stardoc used to work just fine in at least 4.0.0
Description
A clear and concise description of the problem...
Currently, rendering docs via stardoc is broken for rules_rust on newer versions of rules_nodejs because of an update to some of the .bzl files.
(21:15:47) ERROR: error loading package 'wasm_bindgen': in /workdir/wasm_bindgen/wasm_bindgen.bzl: in /workdir/wasm_bindgen/providers.bzl: cannot load '@build_bazel_rules_nodejs//internal/providers:declaration_info.bzl': no such file
There should be an integration test to ensure the //:bzl target actually includes all files such that external workspaces can continue to render stardoc docs.
ERROR: /private/var/tmp/_bazel_user/ed46dd183bde476d0b6a237289845378/external/build_bazel_rules_nodejs/BUILD.bazel:42:12: no such target '@build_bazel_rules_nodejs//internal/generated_file_test:bzl': target 'bzl' not declared in package 'internal/generated_file_test' defined by /private/var/tmp/_bazel_user/ed46dd183bde476d0b6a237289845378/external/build_bazel_rules_nodejs/internal/generated_file_test/BUILD and referenced by '@build_bazel_rules_nodejs//:bzl'
ERROR: /private/var/tmp/_bazel_user/ed46dd183bde476d0b6a237289845378/external/build_bazel_rules_nodejs/BUILD.bazel:42:12: no such target '@build_bazel_rules_nodejs//internal/linker:bzl': target 'bzl' not declared in package 'internal/linker' defined by /private/var/tmp/_bazel_user/ed46dd183bde476d0b6a237289845378/external/build_bazel_rules_nodejs/internal/linker/BUILD.bazel and referenced by '@build_bazel_rules_nodejs//:bzl'
yeah I think the only integration test is to actually run stardoc from userland against our release artifact. And it would have to cover all the APIs, I guess just load()ing all of them is enough
yeah I think the only integration test is to actually run stardoc from userland against our release artifact. And it would have to cover all the APIs, I guess just load()ing all of them is enough
I think as long as something is loaded from top level .bzl files I think it'd generally be fine. I don't think new modules are rapidly added or removed and anything in internal or private should probably not be loaded by users. But I'm definitely lacking in experience here. You'd know better than I would 馃槃
馃悶 bug report
Affected Rule
The issue is caused by the rule:Is this a regression?
Yes, loads and stardoc used to work just fine in at least
4.0.0
Description
A clear and concise description of the problem...Currently, rendering docs via
stardoc
is broken forrules_rust
on newer versions ofrules_nodejs
because of an update to some of the.bzl
files.bazelbuild/rules_rust#984
bazelbuild/rules_rust#953
There should be an integration test to ensure the
//:bzl
target actually includes all files such that external workspaces can continue to render stardoc docs.馃敩 Minimal Reproduction
Likely bazelbuild/rules_rust#953
The text was updated successfully, but these errors were encountered: