Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absent c8 package makes tests fail under bazel coverage #2407

Open
alexeagle opened this issue Jan 19, 2021 · 2 comments
Open

absent c8 package makes tests fail under bazel coverage #2407

alexeagle opened this issue Jan 19, 2021 · 2 comments
Assignees
@alexeagle
Labels
package:builtin not in any of the npm packages

Comments

@alexeagle
Copy link
Collaborator

coverage depending on c8, should it be non-fatal? Doesn't work with generated_file_test for example.

It could warn somewhere. Maybe only with VERBOSE_COVERAGE.

decision: the error message should tell you how to both turn to a warning globally and also turn off for one target.
@alexeagle alexeagle added the package:builtin not in any of the npm packages label Jan 19, 2021
@alexeagle alexeagle self-assigned this Jan 19, 2021
@mattem
Copy link
Collaborator

mattem commented Jan 21, 2021

Related #2407

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Apr 22, 2021
@alexeagle alexeagle removed the Can Close? We will close this in 30 days if there is no further activity label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
package:builtin not in any of the npm packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @mattem