Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch bazel workspace from build_bazel_rules_nodejs to rules_nodejs #2196

Open
alexeagle opened this issue Sep 14, 2020 · 2 comments
Open

Switch bazel workspace from build_bazel_rules_nodejs to rules_nodejs #2196

alexeagle opened this issue Sep 14, 2020 · 2 comments
Labels
cleanup Tech debt, resolving it improves our own velocity fix-in-new-core

Comments

@alexeagle
Copy link
Collaborator

This is in the Bazel rules style guide, and many rules now ship this way (go and docker are still notable exceptions)
@alexeagle alexeagle added this to the 3.0 milestone Sep 14, 2020
@mattem mattem added the cleanup Tech debt, resolving it improves our own velocity label Sep 20, 2020
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Oct 17, 2020
refactor: rename build_bazel_rules_nodejs workspace to rules_nodejs
e4b7662 
BREAKING CHANGE:
You must update all your references such as load statements from
build_bazel_rules_nodejs to just rules_nodejs

fixes bazelbuild#2196
@alexeagle alexeagle mentioned this issue Oct 17, 2020
Closed
@alexeagle
Copy link
Collaborator Author

We'll maybe do this at the end, if we have buildozer commands that mostly patch up users

@mattem
Copy link
Collaborator

mattem commented Nov 10, 2020

Maybe bind can help migrate?

@mattem mattem removed this from the 3.0 milestone Nov 24, 2020
@alexeagle alexeagle added this to the 5.0 milestone Oct 14, 2021
@gregmagolan gregmagolan removed this from the 5.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity fix-in-new-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @gregmagolan @mattem