go_test: combine testinit and wrapper packages into bzltestutil #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testinit was a package used to change directories to the package directory where tests normally run. The wrapper sources were compiled into the test main package and were used to re-execute the test binary in order to capture stdout and stderr and translate verbose test output to XML. The change combines both into the bzltestutil package. Like testinit, it's imported by all generated test mains and should be initialized before any other package outside std. This fixes an issue where we changed directories before re-executing the test binary to capture XML output. If os.Args[0] was a relative path, it would no longer be meaningful. Fixes bazelbuild#2749
jayconrod
pushed a commit
that referenced
this pull request
Dec 23, 2020
testinit was a package used to change directories to the package directory where tests normally run. The wrapper sources were compiled into the test main package and were used to re-execute the test binary in order to capture stdout and stderr and translate verbose test output to XML. The change combines both into the bzltestutil package. Like testinit, it's imported by all generated test mains and should be initialized before any other package outside std. This fixes an issue where we changed directories before re-executing the test binary to capture XML output. If os.Args[0] was a relative path, it would no longer be meaningful. Fixes #2749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testinit was a package used to change directories to the package
directory where tests normally run.
The wrapper sources were compiled into the test main package and were
used to re-execute the test binary in order to capture stdout and
stderr and translate verbose test output to XML.
The change combines both into the bzltestutil package. Like testinit,
it's imported by all generated test mains and should be initialized
before any other package outside std.
This fixes an issue where we changed directories before re-executing
the test binary to capture XML output. If os.Args[0] was a relative
path, it would no longer be meaningful.
Fixes #2749