Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted api grpc.WithBalancerName #412

Closed
easwars opened this issue Mar 16, 2022 · 2 comments
Closed

Remove deleted api grpc.WithBalancerName #412

easwars opened this issue Mar 16, 2022 · 2 comments

Comments

@easwars
Copy link

easwars commented Mar 16, 2022

We (grpc-go team) noticed that the grpc.WithBalancerName API is being used in your repo. This was deprecated about 4 years ago and was deleted recently in grpc/grpc-go#5232.

We would recommend that you replace grpc.WithBalancerName with the following two dial options:

  • Specify the balancer name of your choice using a default service config:
    WithDefaultServiceConfig(fmt.Sprintf({"loadBalancingConfig": [{"%s":{}}]}, balancer.Name))
  • Disable the service config specified by your resolver:
    grpc.WithDisableServiceConfig

Thanks

@ukai
Copy link

ukai commented Apr 25, 2022

with grpc-go@v1.46.0, compile error with undefined: grpc.WithBalancerName

@easwars
Copy link
Author

easwars commented May 9, 2022

with grpc-go@v1.46.0, compile error with undefined: grpc.WithBalancerName

Yes, that API has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants