Upgrade invocation_policy.proto to proto3

[sushain97]

Description of the problem / feature request:

Please upgrade the invocation_policy.proto file to the proto3 syntax.

It's currently proto2:

bazel/src/main/protobuf/invocation_policy.proto

Line 15 in 936196a

syntax = "proto2";

Feature requests: what underlying problem are you trying to solve with this feature?

I'm attempting to generate Ruby bindings for the BES protos defined here:

bazel/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/BUILD

Lines 25 to 35 in 936196a

	proto_library(
	name = "build_event_stream_proto",
	srcs = ["build_event_stream.proto"],
	deps = [
	"//src/main/protobuf:command_line_proto",
	"//src/main/protobuf:failure_details_proto",
	"//src/main/protobuf:invocation_policy_proto",
	"@com_google_protobuf//:duration_proto",
	"@com_google_protobuf//:timestamp_proto",
	],
	)

Unfortunately, it doesn't support proto2: https://developers.google.com/protocol-buffers/docs/reference/ruby-generated.

For the moment only proto3 is supported. Support for proto2 is planned, but not available yet.

Fortunately, this is the only transitive dependency of the BES protos which uses proto2.

[benjaminp]

Is the stated rationale valid after protocolbuffers/protobuf#9003?

[sushain97]

Sorry for the late reply -- it took a while to get a new version rolled out. I agree that the stated rationale is no longer valid. Thanks for the pointer!

However, it still seems like it would be good hygiene to have everything in proto3?

Either way, I'll leave it to the maintainers on whether to close this issue or not.

[coeuvre]

Thanks for the issue. We cannot simply upgrade it proto3 due to internal usages. Closing.