Bats ignores "dotfiles" when I tell it to look for .bats files in the current directory

[exoosh]

Describe the bug

It seems that bats ignores .bats files that start with a leading . when invoked to run on a directory.

To Reproduce

Steps to reproduce the behavior:

1. Create a .foobar.bats
2. run bats .

Expected behavior

I'd expect it to pick up the files if I only give it the directly name.

Environment (please complete the following information):

• Bats version: Bats 1.10.0 (e823c0b)
• operating system (including version):

  $ lsb_release -a
  No LSB modules are available.
  Distributor ID: Ubuntu
  Description:    Ubuntu 22.04.4 LTS
  Release:        22.04
  Codename:       jammy
  

• bash --version:

  $ bash --version
  GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
  Copyright (C) 2020 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
  
  This is free software; you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.
  

• Install method: Git from master

Additional context

I have some shell function libraries named with a leading .. Usually I will locate the "script" under test using something like this: TOTEST="${BATS_TEST_FILENAME%.*}.sh", so simply switch the script extension for .bats.

This works quite nicely, but I noticed in a helper script that I use to both lint the scripts (with ShellCheck) and invoke the test harness, bats won't pick up on .bats files starting with a leading ..

I know by convention these files are hidden and I understand if you say that's a design decision or can't be fixed because it would break existing behavior.

Just wanted to bring to your attention that this use case exists.

Thanks for bats-core!

[martin-schulze-vireso]

I am not sure if this was a deliberate decision. However, it seem like the behavior is inconsistent with regards to -r.

I think we need to harmonize this and probably should also document the intended behavior.

[exoosh]

@martin-schulze-vireso I thought I could work around this by way of setting GLOBIGNORE=".:..", which implicitly sets dotglob. However, then ShellCheck is unhappy with me, which made me test -- to end the list of options and start the list of files (tests). Alas, this isn't supported by bats, I'll open a feature request ticket for that.

The warning I see is:

( GLOBIGNORE=".:.."; bats * )
                          ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

Of course it can be squelched with # shellcheck disable=SC2035 in the line preceding it, but it'd be much cooler if bats-core supported the convention of -- as terminator of options.