Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git bash uses windows binary 'sort' instead of mingw64 #773

Open
CIenthusiast opened this issue Aug 11, 2023 · 2 comments
Open

git bash uses windows binary 'sort' instead of mingw64 #773

CIenthusiast opened this issue Aug 11, 2023 · 2 comments
Labels
Component: Bash Code Everything regarding the bash code Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Size: Large Changes across several files Status: Unconfirmend No reproducer was provided or the reproducer did not work for maintainers. Type: Bug

Comments

@CIenthusiast
Copy link

CIenthusiast commented Aug 11, 2023 •
edited

Describe the bug
First of i want to say that i dont think that this is a BUG of bats-core!

Im running a Jenkins with linux-nodes and windows-nodes due to the nature of the ci which is running on both OS.
For this i have a gitbash as a substitute to execute shell scripts on Jenkins-Pipelines since i want my ci to share all the scripts on every OS.

When running bats under windows via git-bash it can happen that the git bash uses \system32\sort instead of /usr/bin/sort

To Reproduce
I cant really reproduce on my local machine. Only reproducing

  1. Jenkins installation (with a node on windows + gitbash)
  2. execute bats in pipeline with multible test files

Expected behavior
Use the sort of /usr/bin/sort when running under mingw

Environment (please complete the following information):

  • Bats-core v1.10.0
  • windows 10 Pro (1803)
  • GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)

Additional context
Like i said i dont think this is a problem of bats itself. It can be fixed in bats itself tho.
@CIenthusiast CIenthusiast added Priority: NeedsTriage Issue has not been vetted yet Type: Bug labels Aug 11, 2023
@CIenthusiast
Copy link
Author

Please let me know if you require a PR

@martin-schulze-vireso martin-schulze-vireso added Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Status: Unconfirmend No reproducer was provided or the reproducer did not work for maintainers. Component: Bash Code Everything regarding the bash code Size: Large Changes across several files and removed Priority: NeedsTriage Issue has not been vetted yet labels Aug 23, 2023
@martin-schulze-vireso
Copy link
Member

You are very welcome to provide a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Bash Code Everything regarding the bash code Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Size: Large Changes across several files Status: Unconfirmend No reproducer was provided or the reproducer did not work for maintainers. Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martin-schulze-vireso @CIenthusiast