Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short flag unpacker creates bogus CLI for valued flags #662

Closed
martin-schulze-vireso opened this issue Oct 5, 2022 · 0 comments · Fixed by #732
Closed

Short flag unpacker creates bogus CLI for valued flags #662

martin-schulze-vireso opened this issue Oct 5, 2022 · 0 comments · Fixed by #732
Labels
Component: CLI Command line flags, exit code handling, ... Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Type: Bug
Milestone
1.10.0

Comments

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Oct 5, 2022 •
edited

Describe the bug
See #657 for an example

To Reproduce

Use a valued flag in a packed list. E.g.: bats -FT junit will be equivalent to bats --formatter --timing junit. This degrades especially badly when the white space is left out accidentally: bats -j6 is translated to bats -j -6 by the unpacker.

Expected behavior

Flag packs should only contain valued flags at last position or not at all.

Also fix test for -j5, see #657 (comment)_
@martin-schulze-vireso martin-schulze-vireso added Type: Bug Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Component: CLI Command line flags, exit code handling, ... labels Oct 5, 2022
Closed
@martin-schulze-vireso martin-schulze-vireso added this to the 1.9.0 milestone Nov 23, 2022
@martin-schulze-vireso martin-schulze-vireso modified the milestones: 1.9.0, 1.10.0 Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: CLI Command line flags, exit code handling, ... Priority: High Broken behavior in specific environments like in parallel mode or only on some operating systems Type: Bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Disallow valued flags within short flag pack martin-schulze-vireso/bats-core
1 participant
@martin-schulze-vireso