Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation #651

Merged
merged 6 commits into from Sep 18, 2022
Merged

Fix indentation #651

merged 6 commits into from Sep 18, 2022

Conversation

akinomyoga
Copy link
Contributor

I noticed inconsistent indentations in editing the files for #650. Some part of the files uses 4 spaces while double spaces are used in the other part of the same files.

I also noticed that some files (lib/bats-core/formatter.bash, lib/bats-core/semaphore.bash) are entirely indented by 4 spaces, but I have kept these files untouched though I notice that such files conflict with Contributor Guidelines.

@akinomyoga akinomyoga requested a review from a team as a code owner September 11, 2022 20:02
@martin-schulze-vireso martin-schulze-vireso added this to the 1.9.0 milestone Sep 14, 2022
@martin-schulze-vireso
Copy link
Member

This will have to wait for the next release. Maybe we can even get everything under shfmt and instate a test that ensures no deviation.

@akinomyoga
Copy link
Contributor Author

OK, thank you!

@jkroepke
Copy link
Contributor

is shfmt not an option to ensure the correct formatting across the whole bats framework?

@akinomyoga
Copy link
Contributor Author

I thought #651 (comment) is saying shfmt is an option, isn't it?

@jkroepke
Copy link
Contributor

You are correct. Sorry about this.

@akinomyoga
Copy link
Contributor Author

akinomyoga commented Sep 15, 2022

No problem!

martin-schulze-vireso added a commit to akinomyoga/bats-core that referenced this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants