Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bats_require_minimum_version Support in versions pre 1.7.0 #590

Closed
martin-schulze-vireso opened this issue May 15, 2022 · 1 comment
Closed

bats_require_minimum_version Support in versions pre 1.7.0 #590

martin-schulze-vireso opened this issue May 15, 2022 · 1 comment
Labels
Component: Bash Code Everything regarding the bash code Component: Packaging Regarding packaging for NPM, RPM, etc. Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Size: Medium Changes in the same file Type: Enhancement
Milestone
1.8.0

Comments

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented May 15, 2022 •
edited

Is your feature request related to a problem? Please describe.

BW02 instructs users to guard their code with bats_require_minimum_version 1.5.0. However, this function is only available with Bats version 1.7.0, leading to an error even when the version is 1.5.0.

While that is expected for me, since bats_require_minimum_version is not available, it diminishes the value of this function and the warning. It also might be a bad surpise for unaware users.

Describe the solution you'd like
Provide a plugin that backports the function for previous versions.

Describe alternatives you've considered

Additional context
@martin-schulze-vireso martin-schulze-vireso added Priority: NeedsTriage Issue has not been vetted yet Type: Enhancement Component: Bash Code Everything regarding the bash code Component: Packaging Regarding packaging for NPM, RPM, etc. Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Size: Medium Changes in the same file and removed Priority: NeedsTriage Issue has not been vetted yet labels May 15, 2022
@martin-schulze-vireso
Copy link
Member Author

martin-schulze-vireso commented May 19, 2022 •
edited

We now have bats-core/bats-backports. We still need:

@martin-schulze-vireso martin-schulze-vireso added this to the 1.8.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Bash Code Everything regarding the bash code Component: Packaging Regarding packaging for NPM, RPM, etc. Priority: Critical Broken behavior in nearly all environments, e.g. wrong test results, internal bats error Size: Medium Changes in the same file Type: Enhancement
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
1 participant
@martin-schulze-vireso