From 2bdfd60855e2aa18f25932b9e8d48865fb58914d Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Wed, 1 Jun 2022 13:59:46 -0600 Subject: [PATCH] .github: Don't retry tests Besides test retries being bad (they're there for the case that the test intermittently flakes, but mask the case that the code-under-test only intermittently works), this is important in order to remove the `nick-invision/retry@v2.4.0` GitHub action. It has a bug where if there is too much output it marks the test as passing even if it fails. That is very bad, and we cannot permit that type of failure mode in our CI. https://github.com/nick-fields/retry/issues/76 Signed-off-by: Luke Shumaker Signed-off-by: Sirish Bathina --- .../workflows/execute-tests-and-promote.yml | 52 ++++++++----------- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/.github/workflows/execute-tests-and-promote.yml b/.github/workflows/execute-tests-and-promote.yml index 3fac03d00a..b0abb2740c 100644 --- a/.github/workflows/execute-tests-and-promote.yml +++ b/.github/workflows/execute-tests-and-promote.yml @@ -159,24 +159,20 @@ jobs: username: ${{ secrets.GH_DOCKER_BUILD_USERNAME }} password: ${{ secrets.GH_DOCKER_BUILD_TOKEN }} - name: make pytest-${{ matrix.test }} - uses: nick-invision/retry@v2.4.0 - with: - max_attempts: 3 - timeout_minutes: 20 - command: | - export USE_LOCAL_K3S_CLUSTER=1 - sudo sysctl -w fs.file-max=1600000 - sudo sysctl -w fs.inotify.max_user_instances=4096 + run: | + export USE_LOCAL_K3S_CLUSTER=1 + sudo sysctl -w fs.file-max=1600000 + sudo sysctl -w fs.inotify.max_user_instances=4096 - make ci/setup-k3d K3D_CLUSTER_NAME=amb-ci + make ci/setup-k3d K3D_CLUSTER_NAME=amb-ci - export DEV_KUBE_NO_PVC=yes - export KAT_REQ_LIMIT=900 - export TEST_XML_DIR=/tmp/test-logs/xml/ - export DEV_KUBECONFIG=~/.kube/config - export DEV_REGISTRY=${{ secrets.DEV_REGISTRY }} - mkdir -p ${TEST_XML_DIR} - make pytest-${{ matrix.test }} + export DEV_KUBE_NO_PVC=yes + export KAT_REQ_LIMIT=900 + export TEST_XML_DIR=/tmp/test-logs/xml/ + export DEV_KUBECONFIG=~/.kube/config + export DEV_REGISTRY=${{ secrets.DEV_REGISTRY }} + mkdir -p ${TEST_XML_DIR} + make pytest-${{ matrix.test }} - uses: ./.github/actions/after-job if: always() with: @@ -206,21 +202,17 @@ jobs: username: ${{ secrets.GH_DOCKER_BUILD_USERNAME }} password: ${{ secrets.GH_DOCKER_BUILD_TOKEN }} - name: make pytest-${{ matrix.test }} - uses: nick-invision/retry@v2.4.0 - with: - max_attempts: 3 - timeout_minutes: 20 - command: | - sudo sysctl -w fs.file-max=1600000 - sudo sysctl -w fs.inotify.max_user_instances=4096 + run: | + sudo sysctl -w fs.file-max=1600000 + sudo sysctl -w fs.inotify.max_user_instances=4096 - export DEV_KUBE_NO_PVC=yes - export KAT_REQ_LIMIT=900 - export TEST_XML_DIR=/tmp/test-logs/xml/ - export DEV_KUBECONFIG=~/.kube/config - export DEV_REGISTRY=${{ secrets.DEV_REGISTRY }} - mkdir -p ${TEST_XML_DIR} - make pytest-${{ matrix.test }} + export DEV_KUBE_NO_PVC=yes + export KAT_REQ_LIMIT=900 + export TEST_XML_DIR=/tmp/test-logs/xml/ + export DEV_KUBECONFIG=~/.kube/config + export DEV_REGISTRY=${{ secrets.DEV_REGISTRY }} + mkdir -p ${TEST_XML_DIR} + make pytest-${{ matrix.test }} - uses: ./.github/actions/after-job if: always() with: