Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin support for new granular Android 13 storage permissions … #941

Merged
merged 2 commits into from Oct 19, 2022

Conversation

YannickMaljaars
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature: added support for new Android 13 granular media permissions and new alarm permission

⤵️ What is the current behavior?

No support

🆕 What is the new behavior (if this is a feature change)?

Support added

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

ISSUE: 859

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@YannickMaljaars YannickMaljaars marked this pull request as ready for review October 18, 2022 10:26
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 86.51% // Head: 100.00% // Increases project coverage by +13.48% 🎉

Coverage data is based on head (6c68236) compared to base (f1efd8b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           master      #941       +/-   ##
============================================
+ Coverage   86.51%   100.00%   +13.48%     
============================================
  Files           6         1        -5     
  Lines          89        16       -73     
============================================
- Hits           77        16       -61     
+ Misses         12         0       -12     
Impacted Files Coverage Δ
...andler_platform_interface/lib/src/permissions.dart
..._interface/lib/src/method_channel/utils/codec.dart
..._platform_interface/lib/src/permission_status.dart
...lib/src/permission_handler_platform_interface.dart
...ler_platform_interface/lib/src/service_status.dart
...hod_channel/method_channel_permission_handler.dart
permission_handler/lib/permission_handler.dart 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants