Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications required to support Laravel 11 #1509

Closed
KentarouTakeda opened this issue Feb 7, 2024 · 1 comment · Fixed by #1520
Closed

Modifications required to support Laravel 11 #1509

KentarouTakeda opened this issue Feb 7, 2024 · 1 comment · Fixed by #1520

Comments

@KentarouTakeda
Copy link
Contributor

Hello, Laravel 11 will be released soon.

Overview

I am using the 11.x-dev branch under development to check the operation of Laravel IDE Helper, but there are some places where it does not work due to breaking changes on the Laravel side.

This version update will require modifications not only to composer.json and CI, but also to the implementation. Here is a summary of them.

Details

PHPUnit version upgrade

orchestra/testbench: ^9, which is required for testing with Laravel 11, requires phpunit/phpunit: ^10.5. We need to widen the version range with require-dev.

Support for Doctrine DBAL removal

Related: laravel/framework#48864

All functionality related to Doctrine DBAL has been removed. Not only does Laravel itself not use it, public methods such as getDoctrineSchemaManager() have been removed, and classes related to Connection have also been significantly refactored.

Laravel IDE Helper depends on many of these features, so when supporting Laravel 11 we will need to re-implement it using a different method.

Change migration method for floating-point types

Related: laravel/framework#48861

Some of migration methods for setting columns using a floating-point type has been changed.

The Laravel IDE Helper implementation code is not involved in the migration method, but it is referenced from the test code. Correcting is required for the relevant parts.

Adding methods to Authenticatable contract

Related: laravel/framework#48665

Implementation of rehashPasswordIfRequired() is now required. It is referenced as User implements Authenticatable in the test code, so it needs to be modified to be contract compliant.

@barryvdh
Copy link
Owner

Fixed with #1520
Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants