Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont show diff if no base-lcov-file #240

Open
TanguyRMalou opened this issue Jul 24, 2023 · 1 comment
Open

Dont show diff if no base-lcov-file #240

TanguyRMalou opened this issue Jul 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@TanguyRMalou
Copy link

In the readme, there this description for the base-lcov-file argument :
Lcov.info file that would be used to compare code coverage. The comparison will be disabled if the file is not passed

But if I don't pass and lcov file, I have the line : Your code coverage diff: NaN% ▴ but it shouldn't be here according to the description

@vitaliimelnychuk
Copy link
Member

Hello @TanguyRMalou!

Thanks for reporting it, you're right - it shouldn't be there in the first place. Feel free to create a PR once you have a chance.

Meantime, can you post your configuration of action here as well?

@vitaliimelnychuk vitaliimelnychuk added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants