Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy warning, format github action ci #125

Merged
merged 3 commits into from Dec 14, 2022
Merged

Conversation

baoyachi
Copy link
Owner

No description provided.

src/lib.rs Outdated
@@ -445,13 +445,13 @@ impl Shadow {

// append gen const
for k in self.map.keys() {
let tmp = format!(r#"{}println!("{}:{{}}", {});{}"#, "\t", k, k, "\n");
let tmp = format!(r#"{}println!("{k}:{k}");{}"#, "\t", "\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baoyachi I think you want to rebase this PR on top of master.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.

Copy link
Contributor

@sameo sameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I did not fix the examples.

@baoyachi baoyachi merged commit 0ec3eaf into master Dec 14, 2022
@baoyachi baoyachi deleted the fix_clippy_warning branch December 14, 2022 13:28
@baoyachi
Copy link
Owner Author

Hi @sameo . shadow-rs publised new version, please use:

shadow-rs = "0.19.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants