shadow-rs: Fix linter on generated code #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated print_built_in() function triggers uninlined_format_args linter warning. See https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args With that fix, it generates `"\tprintln!("FOO: {FOO}");\n"` code strings. Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
|
Thx again. @sameo |
sameo
added a commit
to sameo/attestation-service
that referenced
this pull request
Dec 14, 2022
crates.io shadow_rs makes clippy fail, but this is fixed with baoyachi/shadow-rs#123 and baoyachi/shadow-rs#124. Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
sameo
added a commit
to confidential-containers/attestation-service
that referenced
this pull request
Dec 16, 2022
crates.io shadow_rs makes clippy fail, but this is fixed with baoyachi/shadow-rs#123 and baoyachi/shadow-rs#124. Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Xynnn007
pushed a commit
to Xynnn007/kbs
that referenced
this pull request
Nov 10, 2023
crates.io shadow_rs makes clippy fail, but this is fixed with baoyachi/shadow-rs#123 and baoyachi/shadow-rs#124. Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Xynnn007
pushed a commit
to confidential-containers/trustee
that referenced
this pull request
Nov 10, 2023
crates.io shadow_rs makes clippy fail, but this is fixed with baoyachi/shadow-rs#123 and baoyachi/shadow-rs#124. Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated print_built_in() function triggers uninlined_format_args linter warning.
See https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
With that fix, it generates
"\tprintln!("FOO: {FOO}");\n"code strings.Signed-off-by: Samuel Ortiz sameo@rivosinc.com