Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodingError is raised when checking code strings containing symbol literals with invalid UTF-8 chars for completeness #36

Open
egwspiti opened this issue Feb 6, 2016 · 2 comments

Comments

@egwspiti
Copy link

egwspiti commented Feb 6, 2016

> MethodSource.complete_expression?('x = :"\xC3"')
 => EncodingError: invalid encoding symbol

Although this code string has invalid utf-8 chars, it is complete, and thus true should be returned.

@kyrylo
Copy link
Collaborator

kyrylo commented Feb 6, 2016

I don't think it's possible to fix this easily given the mechanism this (and even my (fast_method_source)) library works.

@egwspiti
Copy link
Author

egwspiti commented Feb 8, 2016

Then I guess pry/pry#1516 should be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants