Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping strategy&trade page bugs #1210

Closed
2 tasks done
Costa769 opened this issue May 8, 2024 · 0 comments · Fixed by #1209
Closed
2 tasks done

Overlapping strategy&trade page bugs #1210

Costa769 opened this issue May 8, 2024 · 0 comments · Fixed by #1209
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Costa769
Copy link
Collaborator

Costa769 commented May 8, 2024

  • Remove market price indication

Open deposit/withdraw page of the overlapping strategy that has no market price

Expected:

  • No market price indicator is displayed on the price range chart
  • No "Market price provided by coingecko" text displayed
  • Spread indication on the price range chart is centered

Actual:

image

  • Unknown price & slippage warning message
  1. Go to trade page
  2. Select a token that has no market price

Expected:
Show a warning message "Notice: price & slippage are unknown" in orange like every other warning message on the app
Actual:
image

@Costa769 Costa769 added the bug Something isn't working label May 8, 2024
@Costa769 Costa769 added this to the RC1 milestone May 8, 2024
@tiagofilipenunes tiagofilipenunes linked a pull request May 9, 2024 that will close this issue
@tiagofilipenunes tiagofilipenunes self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants