FEAT: Allow interval option from environment variable #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpow
changed the title
|
Nice! Can you add a test and update the readme please?
…Sent from my iPhone
On Aug 30, 2021, at 14:03, Chris Power ***@***.***> wrote:
Starting our app in NextJS dev takes a bit longer to finishing compilation. Hitting the / route with wait-on every two seconds while compiling leads to the app constantly re-compiling and rarely finishing it's build before the timeout ends.
Adding an option for interval would be great, to allow us to check our route much less frequently.
You can view, comment on, or merge this pull request online at:
#315
Commit Summary
Allow interval option from environment variable
File Changes
M src/index.js (8)
Patch Links:
https://github.com/bahmutov/start-server-and-test/pull/315.patch
https://github.com/bahmutov/start-server-and-test/pull/315.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
sure! will do today. thanks! |
|
@bahmutov added a demo for the ENV vars, lemme know if that works for you, thanks again! |
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting our app in NextJS dev takes a bit longer to finishing compilation. Hitting the
/route withwait-onevery two seconds while compiling leads to the app constantly re-compiling and rarely finishing it's build before the timeout ends.Adding an option for interval would be great, to allow us to check our route much less frequently.
In this PR I'm adding this option as an ENV variable, sticking to the current convention for TIMEOUT