Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubernetes-frontend): use kubernetes-models types instead of kubernetes/client-node types #17854

Open
mclarke47 opened this issue May 17, 2023 · 3 comments
Labels
area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. will-fix We will fix this at some point

Comments

@mclarke47
Copy link
Collaborator

The types in kubernetes/client-node are not a great fit for the frontend since:

  1. The library is designed to be used only server side and thus some functionality doesn't work
  2. We transfer the data from the backend to the frontend and so some types don't match the expected types in kubernetes/client-node (basically all dates, they are strings but the library expects them to be JS Date)
@mclarke47 mclarke47 added the area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. label May 17, 2023
@mclarke47
Copy link
Collaborator Author

FYI @jamieklassen

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 16, 2023
@mclarke47 mclarke47 added will-fix We will fix this at some point and removed stale labels Jul 17, 2023
@mclarke47
Copy link
Collaborator Author

kubernetes-client/javascript#414

There is a vulnerability in the requests package which client-node uses which makes this change somewhat more urgent to remove from the UI packages to limit the amount of places the vulnerability will appear. Then we need to remove uses of the client-node unless they can remove the dependence on requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. will-fix We will fix this at some point
Projects
None yet
Development

No branches or pull requests

1 participant