Refactor buildBabelOptions and introduce getSupportedExtensions. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "one true source" of information should be `buildBabelOptions`, this refactors slightly to ensure that `transpileTree` is not using internal customized babel config logic.
…ions` This more correctly reflects what the method is doing, and what it is for.
rwjblue
force-pushed
the
move-babel-options-building-to-buildBabelOptions
branch
from
938b5dc
to
37a06da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildBabelOptionsaccounts forbabel.config.js._getDefaultBabelOptionstobuildBroccoliBabelTranspilerOptionsgetSupportedExtensionsmethod.The goal here is to fixup some options building issues, and expose a public API that ember-auto-import can use that doesn't rely on the bug @ef4 reported in #227.
.tsfiles not included with latestember-cli-babelembroider-build/ember-auto-import#359