Fix presets array bug #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unblocks ember-cli/ember-cli#7848 and fixes ember-cli/ember-cli#7850 |
|
/cc @stefanpenner and @kellyselden |
rwjblue
reviewed
May 26, 2018
index.js
Outdated
| @@ -221,9 +221,13 @@ module.exports = { | |||
| userPostTransformPlugins | |||
| ).filter(Boolean); | |||
|
|
|||
| options.presets = [ | |||
| shouldRunPresetEnv && this._getPresetEnvPlugins(addonProvidedConfig), | |||
| ] | |||
There was a problem hiding this comment.
Would it be easier to add .filter(Boolean) here instead?
There was a problem hiding this comment.
I think the condition is easier to read than &&
There was a problem hiding this comment.
I think I agree with @rwjblue, I think the consistency with the above .filter(Boolean) would be better.
kellyselden
approved these changes
May 26, 2018
In `ember-cli` when using `DELAYED_TRANSPILATION` feature, we explicitly set `disablePresetEnv` flag to `true`. `shouldRunPresetEnv` is a negation of `disablePresetEnv`. Prior to this change `options.presets` was an array with one `false` item in it (`shouldRunPresetEnv` was set to `false`) and would let files be transplied when `DELAYED_TRANSPILATION` was enabled. Useful links: + https://github.com/ember-cli/ember-cli/blob/2e0cade64c4698cc48b1fdc20fda2219e63cc973/lib/models/addon.js#L256
|
@rwjblue @kellyselden comment addressed, I can't merge so w/e you're ready 😺 |
|
I’ll get it released in an hour or so... |
|
Released in v6.14.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ember-cliwhen usingDELAYED_TRANSPILATIONfeature, we explicitlyset
disablePresetEnvflag totrue.shouldRunPresetEnvis anegation of
disablePresetEnv.Prior to this change
options.presetswas an array with onefalseitem in it (
shouldRunPresetEnvwas set tofalse) and would not let filesbe transplied when
DELAYED_TRANSPILATIONwas enabled.Useful links: