Include addon name directory in 'treeForAddon' (mitigate issues with Embroider when using external helpers) #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespierce
force-pushed
the
tree_include_addon
branch
from
cb7fb6c
to
3f1564a
Compare
rwjblue
reviewed
Apr 27, 2021
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
treeForAddonmethod provided byember-cliensures that all compiled assets are put into a directory named after the addon itself (see https://github.com/ember-cli/ember-cli/blob/9911f5493c00986ac2d0be104a80152426240a30/lib/models/addon.js#L1196)treeForAddonmethod, however,ember-cli-babelcurrently doesn't do that for the babel helpers.Changes
Funnelthat includes the addon module name directory when building the Babel helpers (using the samemoduleNamemethod that the base addon class uses.