Skip to content

Update modules API polyfill to avoid TypeScript related errors. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 29, 2020

When an imported Ember module was used as both a type and a value, the value would be replaced properly with the Ember global but when the Babel plugin attempted to rewrite the type reference to the import an error was thrown.

See ember-cli/babel-plugin-ember-modules-api-polyfill#110 for a more detailed description.

Thanks for the fix @fivetanley!

@rwjblue rwjblue added the bug label May 29, 2020
@rwjblue rwjblue merged commit 2ce3711 into master May 29, 2020
@rwjblue rwjblue deleted the update-modules-polyfill branch May 29, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant