From 5edb14c8f1efe6ccfc4ea9857fac4c5edd73124f Mon Sep 17 00:00:00 2001 From: Matthew Schupack Date: Fri, 17 May 2019 06:55:12 -0400 Subject: [PATCH 1/2] use console.warn for warning --- packages/babel-preset-env/src/normalize-options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-preset-env/src/normalize-options.js b/packages/babel-preset-env/src/normalize-options.js index edbaaa52e984..76b13f5a7e39 100644 --- a/packages/babel-preset-env/src/normalize-options.js +++ b/packages/babel-preset-env/src/normalize-options.js @@ -203,7 +203,7 @@ export function normalizeCoreJSOption( if (useBuiltIns && corejs === undefined) { rawVersion = 2; - console.log( + console.warn( "\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + "core-js version. Currently, we assume version 2.x when no version " + "is passed. Since this default version will likely change in future " + From e3073a2dc5e11a4a850ad628f4937496d3cd6ed3 Mon Sep 17 00:00:00 2001 From: Matthew Schupack Date: Fri, 17 May 2019 07:42:07 -0400 Subject: [PATCH 2/2] fix tests --- .../debug-fixtures/entry-no-corejs-no-import/stderr.txt | 6 ++++++ .../debug-fixtures/entry-no-corejs-no-import/stdout.txt | 7 ------- .../entry-no-corejs-shippedProposals/stderr.txt | 6 ++++++ .../entry-no-corejs-shippedProposals/stdout.txt | 7 ------- .../test/debug-fixtures/entry-no-corejs-uglify/stderr.txt | 6 ++++++ .../test/debug-fixtures/entry-no-corejs-uglify/stdout.txt | 8 -------- .../test/debug-fixtures/entry-no-corejs/stderr.txt | 6 ++++++ .../test/debug-fixtures/entry-no-corejs/stdout.txt | 7 ------- .../test/debug-fixtures/usage-no-corejs-none/stderr.txt | 6 ++++++ .../test/debug-fixtures/usage-no-corejs-none/stdout.txt | 7 ------- .../test/debug-fixtures/usage-no-corejs/stderr.txt | 6 ++++++ .../test/debug-fixtures/usage-no-corejs/stdout.txt | 7 ------- 12 files changed, 36 insertions(+), 43 deletions(-) create mode 100644 packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stderr.txt create mode 100644 packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stderr.txt create mode 100644 packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stderr.txt create mode 100644 packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stderr.txt create mode 100644 packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stderr.txt create mode 100644 packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stderr.txt diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stdout.txt index e17f65ad8f8e..ac37a584bfdf 100644 --- a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-no-import/stdout.txt @@ -1,10 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - @babel/preset-env: `DEBUG` option Using targets: diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stdout.txt index 4db1cd916373..04e8ce0e5829 100644 --- a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-shippedProposals/stdout.txt @@ -1,10 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - @babel/preset-env: `DEBUG` option Using targets: diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stdout.txt index aa3b5a6298be..2a97e7973107 100644 --- a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs-uglify/stdout.txt @@ -1,11 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - - The uglify target has been deprecated. Set the top level option `forceAllTransforms: true` instead. diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stdout.txt index 6467473c2b91..943bad68b9b1 100644 --- a/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/entry-no-corejs/stdout.txt @@ -1,10 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - @babel/preset-env: `DEBUG` option Using targets: diff --git a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stdout.txt index cd94fc79154f..fafdcfca187c 100644 --- a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs-none/stdout.txt @@ -1,10 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - @babel/preset-env: `DEBUG` option Using targets: diff --git a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stderr.txt b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stderr.txt new file mode 100644 index 000000000000..dbee5e8f3eb3 --- /dev/null +++ b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stderr.txt @@ -0,0 +1,6 @@ +WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. + +You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: + + npm install --save core-js@2 npm install --save core-js@3 + yarn add core-js@2 yarn add core-js@3 \ No newline at end of file diff --git a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stdout.txt b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stdout.txt index 1f62218fb7cb..8d1136d823bd 100644 --- a/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stdout.txt +++ b/packages/babel-preset-env/test/debug-fixtures/usage-no-corejs/stdout.txt @@ -1,10 +1,3 @@ -WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. - -You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: - - npm install --save core-js@2 npm install --save core-js@3 - yarn add core-js@2 yarn add core-js@3 - @babel/preset-env: `DEBUG` option Using targets: