Fixed null error in plugin opts and added a test for it #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10762/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10759/ |
…e and undefined cases Co-Authored-By: divbhasin <divbest99@gmail.com>
nicolo-ribaudo
added
area: errors
pkg: core
PR: Polish 💅
nicolo-ribaudo
approved these changes
May 6, 2019
existentialism
approved these changes
May 7, 2019
|
Thank you! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is my first PR, so I would welcome as much feedback as possible to learn as quickly as possible.
As described in #9936, there is an error when a null option is passed with a plugin in someone's .babelrc file. As suggested by @nicolo-ribaudo, I made a small change to check for the null value in packages/babel-core/src/config/validation/option-assertions.js and added the appropriate test in packages/babel-core/test/option-manager.js. The test only checks one plugin, as the error would just extend to multiple plugins, if that is the case.