Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing space in error messages #9909

Merged
merged 1 commit into from Apr 29, 2019
Merged

Add missing space in error messages #9909

merged 1 commit into from Apr 29, 2019

Conversation

pnavarrc
Copy link
Contributor

@pnavarrc pnavarrc commented Apr 26, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR adds a missing space in 4 error messages. The original error message is:

Error: You appear to be using a plugin with an async traversal visitor, which your current version of Babel does not support.If you're using a published plugin, you may need to upgrade your @babel/core version.

After this change, the error message will look like:

Error: You appear to be using a plugin with an async traversal visitor, which your current version of Babel does not support. If you're using a published plugin, you may need to upgrade your @babel/core version.

NOTE: Let me know if I need to change something in this PR, I couldn't find guidelines for changes this small in the contributing guide or in the PR template. If this is already covered in another PR feel free to close this PR. Awesome project, thanks!

@nicolo-ribaudo
Copy link
Member

The changes look good, but this commit a be [skip ci] since there might be tests testing t 😛

@nicolo-ribaudo nicolo-ribaudo added area: errors pkg: core PR: Polish 💅 A type of pull request used for our changelog categories labels Apr 26, 2019
@pnavarrc
Copy link
Contributor Author

Thanks @nicolo-ribaudo, updated. It seems that something else is failing (https://circleci.com/gh/babel/babel/10743#tests/containers/0), let me know if there is something else to update in this PR!

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 29, 2019

It's ok, it has been fixed on master. Thank you!

@nicolo-ribaudo nicolo-ribaudo merged commit 16e17c5 into babel:master Apr 29, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants