Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9232, add some missed modules to @babel/polyfill/noConflict #9780

Merged
merged 1 commit into from Apr 2, 2019
Merged

Fix #9232, add some missed modules to @babel/polyfill/noConflict #9780

merged 1 commit into from Apr 2, 2019

Conversation

zloirock
Copy link
Member

@zloirock zloirock commented Mar 28, 2019

Fixes #9232

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10631/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10631/

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: polyfill labels Mar 28, 2019
@xtuc
Copy link
Member

xtuc commented Apr 2, 2019

Could we first merge my PR #9808 first, which unifies the normal and noConflict mode. I can rebase this one if needed.

@zloirock
Copy link
Member Author

zloirock commented Apr 2, 2019

@xtuc initially, I wanted to do it in this PR. However, since @babel/polyfill is deprecated and too many people use a link to packages/babel-polyfill/src/index.js for show that @babel/polyfill is just core-js and regenerator-runtime import, I decided not to do it.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 2, 2019

Well, people can just link packages/babel-polyfill/src/noConflict.js. If you want, we can add a comment in index.js pointing to that file.

@zloirock
Copy link
Member Author

zloirock commented Apr 2, 2019

@nicolo-ribaudo I mean existent links.

I don't care.

@xtuc
Copy link
Member

xtuc commented Apr 2, 2019

Sorry I think i'm missing something. Users that require packages/babel-polyfill/src/index.js will require the noConflict.js + actual conflict code under the hood. I don't think it's breaking exisiting links.

@zloirock
Copy link
Member Author

zloirock commented Apr 2, 2019

@xtuc it's about links in the documentation / articles / comments.

@nicolo-ribaudo nicolo-ribaudo merged commit 00cae77 into babel:master Apr 2, 2019
@zloirock zloirock deleted the fix-9232 branch April 3, 2019 02:40
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: polyfill PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when @babel/polyfill is used with webpack 5 it throws a ReferenceError: global is not defined
5 participants