Correctly check for-in and for-of loop for invalid left-hand side #9768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Spec Compliance 👓
danez
added this to In progress
in Parser: Spec Compliance, Refactoring and Performance
via automation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10617/ |
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from In progress
to Reviewed
Mar 25, 2019
nicolo-ribaudo
approved these changes
Mar 25, 2019
existentialism
approved these changes
Mar 26, 2019
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from Reviewed
to Done
Mar 26, 2019
This was referenced Aug 17, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were allowing assignments in for-in loops
which is not allowed. The only exception is
for(var x = 1 in list);in non-strict mode.I refactored this checks and moved them into
parseForIn(). This also improves the error messages.Tests were already present
also did the same in acorn: acornjs/acorn#821