Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse right-hand-side of for/of as an assignment expression #9767

Merged
merged 1 commit into from Mar 26, 2019
Merged

Parse right-hand-side of for/of as an assignment expression #9767

merged 1 commit into from Mar 26, 2019

Conversation

danez
Copy link
Member

@danez danez commented Mar 25, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This was allowing invalid syntax being parsed.

@danez danez added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser labels Mar 25, 2019
@danez danez added this to In progress in Parser: Spec Compliance, Refactoring and Performance via automation Mar 25, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Mar 25, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10604/

@danez danez merged commit 7f44274 into babel:master Mar 26, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Mar 26, 2019
@danez danez deleted the for-of-assign branch March 26, 2019 01:15
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants