From eb54c3954ba1569f6f059a2fdd87f6827e9e7b51 Mon Sep 17 00:00:00 2001 From: Jimmy Jia Date: Thu, 7 Mar 2019 15:36:08 -0500 Subject: [PATCH 1/2] fix: Don't transpile ES7 symbol properties --- packages/babel-plugin-transform-runtime/src/definitions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/babel-plugin-transform-runtime/src/definitions.js b/packages/babel-plugin-transform-runtime/src/definitions.js index ac044910a08e..1f8907fd67bc 100644 --- a/packages/babel-plugin-transform-runtime/src/definitions.js +++ b/packages/babel-plugin-transform-runtime/src/definitions.js @@ -109,7 +109,8 @@ export default runtimeVersion => { : {}), Symbol: { - asyncIterator: "symbol/async-iterator", + // FIXME: Disabled to work zloirock/core-js#262. + // asyncIterator: "symbol/async-iterator", for: "symbol/for", hasInstance: "symbol/has-instance", isConcatSpreadable: "symbol/is-concat-spreadable", From 60234f5909a93b2b09d00e754c7764433c6a0dd9 Mon Sep 17 00:00:00 2001 From: Jimmy Jia Date: Thu, 7 Mar 2019 21:59:38 -0500 Subject: [PATCH 2/2] avoid breaking change --- .../scripts/build-dist.js | 10 +++++++++- .../babel-plugin-transform-runtime/src/definitions.js | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/babel-plugin-transform-runtime/scripts/build-dist.js b/packages/babel-plugin-transform-runtime/scripts/build-dist.js index 4f8375d284e9..590440aff352 100644 --- a/packages/babel-plugin-transform-runtime/scripts/build-dist.js +++ b/packages/babel-plugin-transform-runtime/scripts/build-dist.js @@ -19,7 +19,15 @@ writeHelpers("@babel/runtime-corejs2", { corejs: 2 }); function writeCoreJS2(runtimeName) { const pkgDirname = getRuntimeRoot(runtimeName); - const paths = ["is-iterable", "get-iterator"]; + const paths = [ + "is-iterable", + "get-iterator", + + // This was previously in definitions, but was removed to work around + // zloirock/core-js#262. We need to keep it in @babel/runtime-corejs2 to + // avoid a breaking change there. + "symbol/async-iterator", + ]; Object.keys(corejs2Definitions.builtins).forEach(key => { const path = corejs2Definitions.builtins[key]; diff --git a/packages/babel-plugin-transform-runtime/src/definitions.js b/packages/babel-plugin-transform-runtime/src/definitions.js index 1f8907fd67bc..b0874d080338 100644 --- a/packages/babel-plugin-transform-runtime/src/definitions.js +++ b/packages/babel-plugin-transform-runtime/src/definitions.js @@ -109,7 +109,7 @@ export default runtimeVersion => { : {}), Symbol: { - // FIXME: Disabled to work zloirock/core-js#262. + // FIXME: Disabled to work around zloirock/core-js#262. // asyncIterator: "symbol/async-iterator", for: "symbol/for", hasInstance: "symbol/has-instance",