Destructuring: Fix handling of impure computed keys with object rest #9416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in
destructuring
where impure computed keys in object patterns would be evaluated twice in the presence of rest properties.The
object-rest-spread
plugin handles this correctly (with an implementation that couldn't be directly copied intodestructuring
, unfortunately) and is the source of theexec
test I've added here. I've also amended this test in both plugins to assert that the RHS expression is evaluated before the computed key expressions.