[flow] Explicit inexact objects with ...
#8884
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9276/ |
existentialism
added
area: flow
PR: New Feature 🚀
| case tt.braceBarR: | ||
| this.flowObjectTypeSemicolon(); | ||
| switch (this.state.type) { | ||
| case tt.braceR: |
There was a problem hiding this comment.
Nit: I think that this code would be more readable without nested switch statemets:
let isInexactToken = this.eat(tt.comma) || this.eat(tt.semi);
if (this.match(tt.braceR)) {
if (allowInexact) return true;
this.unexpected(null, "Explicit inexact syntax is only allowed inside inexact objects");
}
if (this.match(tt.braceBarR)) {
this.unexpected(null, "Explicit inexact syntax cannot appear inside an explicit exact object type");
}
if (isInexactToken) {
this.unexpected(null, "Explicit inexact syntax must appear at the end of an inexact object");
}
node.argument = this.flowParseType();
return this.finishNode(node, "ObjectTypeSpreadProperty");Do what you prefer though
There was a problem hiding this comment.
I like this better, will follow up
| case tt.comma: | ||
| case tt.semi: | ||
| case tt.braceR: | ||
| case tt.braceBarR: { |
There was a problem hiding this comment.
I think that you can also remove this outer switch, since the ifs already handle only these four cases.
| null, | ||
| "Explicit inexact syntax cannot appear inside an explicit exact object type", | ||
| ); | ||
| return false; |
There was a problem hiding this comment.
Those retuens aren't needed, since this.unexpected already throws. If you want to be explicit, I think that it would be more correct to use throw this.unexpected.
nicolo-ribaudo
dismissed
their stale review
Wrong button in the last review 😅
|
@nicolo-ribaudo, thanks for the feedback! I'll backport this to 6.xx as well, since I assume there's still a bunch of flow projects out there that haven't upgraded to babel 7 yet. |
|
Actually, it's not clear to me where to start with backporting this change. The |
|
We are not going to release new Babel 6 version, especially for new features. |
|
Any idea when the next babel release is / if this will be in it? |
|
@jbrown215 no exact date... soon though? :) |
* master: (222 commits) Set correct methods name Use toPropertyKey in the "decorate" helper Allow function types in type params within arrow return types (babel#8954) Fix message when plugin of a wrong type is passed (babel#8950) rename colliding let bindings with for loop init (babel#8937) edge incomplete support for arrow destructuring (babel babel#8349) (babel#8926) fix single-arg async arrows when retainLines=true (babel#8868) [flow] Explicit inexact objects with `...` (babel#8884) Update preset-env data (babel#8898) Treat break inside block inside loop (babel#8914) fixed "source map" formatting in comment (babel#8878) [skip ci] fix typo in contributing guidelines (babel#8901) [skip ci] fix: Expression x === 'y' && '' should not evaluate to undefined. (babel#8880) fixed an extra word Fixes babel#8865 (babel#8866) v7.1.4 v7.1.3 Bump Babel deps (babel#8770) flow-bin@0.82.0 (babel#8832) Insertafter jsx fix (babel#8833) ... # Conflicts: # packages/babel-parser/src/tokenizer/index.js # packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-numeric-literal/options.json # packages/babel-parser/test/fixtures/experimental/pipeline-operator/invalid-proposal/options.json
lock
bot
added
the
outdated
In facebook/flow@1ac9130, flow started parsing
{foo: number, ...}as an inexact object. This is part of a larger effort to move to parsing object types as exact by default....can only appear at the end of the props list, and it cannot appear inside{||}. Additionally, it can only appear inside object types, and not interfaces, declare classes, or declare interfaces....also supports trailing commas.For any object type, but not in declare class, declare interface, or interface, the
ObjectTypeAnnotationrepresenting it now has aninexactproperty. This property is true if and only if...was used to indicate the inexactness. To minimize confusion, it is best to readexactasexplicitly exact(containing curlybars) andinexactasexplicitly inexact(containing...). This mimics the behavior in Flow's estree output facebook/flow@231256c. In a few releases, we will get rid of the exact flag entirely, which will be a breaking change to other tools.Tests had to be re-recorded to include the
inexactflag. I separated the re-recording of old tests into a separate commit for reviewing ease.Let me know if there is anything else I need to update in this change.