New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Expression x === 'y' && '' should not evaluate to undefined. #8880
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9257/ |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9256/ |
Can we add a test? |
Added a test, but can't see how to test the test without the output getting lost in 1711 unrelated tests which somehow fail for me with stuff like |
@Cyp, did you run Also, reference our contributing guidelines for running just a single test! |
No — that worked, all tests pass for me now, thanks. |
* master: (222 commits) Set correct methods name Use toPropertyKey in the "decorate" helper Allow function types in type params within arrow return types (babel#8954) Fix message when plugin of a wrong type is passed (babel#8950) rename colliding let bindings with for loop init (babel#8937) edge incomplete support for arrow destructuring (babel babel#8349) (babel#8926) fix single-arg async arrows when retainLines=true (babel#8868) [flow] Explicit inexact objects with `...` (babel#8884) Update preset-env data (babel#8898) Treat break inside block inside loop (babel#8914) fixed "source map" formatting in comment (babel#8878) [skip ci] fix typo in contributing guidelines (babel#8901) [skip ci] fix: Expression x === 'y' && '' should not evaluate to undefined. (babel#8880) fixed an extra word Fixes babel#8865 (babel#8866) v7.1.4 v7.1.3 Bump Babel deps (babel#8770) flow-bin@0.82.0 (babel#8832) Insertafter jsx fix (babel#8833) ... # Conflicts: # packages/babel-parser/src/tokenizer/index.js # packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-numeric-literal/options.json # packages/babel-parser/test/fixtures/experimental/pipeline-operator/invalid-proposal/options.json
Should fix babel/minify#908: Expressions of the form
x === "foo" && ""
were incorrectly minified toundefined
. This was due to evaluate() on&&
giving the wrong result when only the right-hand side is known and falsy.