Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some missing parens cases with OptionalMemberExpression in generator #8751

Merged
merged 2 commits into from Sep 23, 2018

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #8733
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Sep 22, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 22, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9150/

node: Object,
parent: Object,
): boolean {
return t.isMemberExpression(parent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't parentheses also needed when the parent is a CallExpression? ((a?.b)())

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@existentialism existentialism merged commit 9f407e0 into master Sep 23, 2018
@existentialism existentialism deleted the issue8733 branch September 23, 2018 15:54
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/generator: Incorrect parens in scenario involving OptionalMemberExpression
4 participants