Remove Babylon plugins for features already merged to the ECMAScript spec #8448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
nicolo-ribaudo
commented
Aug 10, 2018
| "objectRestSpread", | ||
| "classProperties", | ||
| ); | ||
| parserOpts.plugins.push("typescript", "classProperties"); |
There was a problem hiding this comment.
This is a breaking change if someone uses an older Babylon version. Since we are in RC, I can revert it if you prefer.
nicolo-ribaudo
force-pushed
the
remove-babylon-plugins
branch
from
74e2fe8
to
a734266
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9332/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8795/ |
danez
approved these changes
Nov 3, 2018
nicolo-ribaudo
force-pushed
the
remove-babylon-plugins
branch
2 times, most recently
from
d1425ef
to
d80b02a
Compare
…spec - objectRestSpread (2018) - asyncGenerators (2018) - optionalCatchBInding (2019) - jsonStrings (2019)
nicolo-ribaudo
force-pushed
the
remove-babylon-plugins
branch
from
cbd9e01
to
386dea9
Compare
This was referenced Nov 7, 2018
sindresorhus
pushed a commit
to refined-github/refined-github
that referenced
this pull request
Nov 11, 2018
Follows babel/babel#8448 Context in review comment: https://github.com/sindresorhus/refined-github/pull/1449/files#r216110819
This was referenced Nov 12, 2018
2 tasks
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now enabled by default:
TODO (after this PR):
@babel/plugin-syntax-*packages.@babel/plugin-proposal-*packages.@babel/plugin-transform-*packages.