Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions from renamer.js. #5965

Merged
merged 1 commit into from Jul 20, 2017
Merged

Remove unused functions from renamer.js. #5965

merged 1 commit into from Jul 20, 2017

Conversation

mcav
Copy link
Contributor

@mcav mcav commented Jul 18, 2017

Firefox emits warnings about unreachable code after return statements. This patch removes those unused functions entirely (as suggested in #5962) to silence these errors.

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? n/a
Tests Added/Pass? n/a
Fixed Tickets
License MIT
Doc PR
Dependency Changes

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

@xtuc xtuc added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Polish 💅 A type of pull request used for our changelog categories labels Jul 20, 2017
@hzoo hzoo merged commit fe13ba8 into babel:master Jul 20, 2017
@hzoo hzoo removed the PR: Polish 💅 A type of pull request used for our changelog categories label Jul 20, 2017
@hzoo
Copy link
Member

hzoo commented Jul 20, 2017

Cool thanks 😄

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants