New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5768 #5811
Fix 5768 #5811
Conversation
- adds a failing test based on description in babel#5768 - handles ObjectPattern and ArrayPattern
@joshwnj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @benjamn and @loganfsmyth to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5811 +/- ##
==========================================
- Coverage 84.75% 84.74% -0.01%
==========================================
Files 204 204
Lines 9608 9622 +14
Branches 2702 2708 +6
==========================================
+ Hits 8143 8154 +11
Misses 981 981
- Partials 484 487 +3
Continue to review full report at Codecov.
|
Nice work @joshwnj! |
Hm realized this is also against master instead of 7.0 heh |
@hzoo cheers!
oh, sorry! :) So for future reference all PRs like this should target the 7.0 branch? |
Well |
I see, no worries. Want me to put together another PR against 7.0 for this, or you've got it? |
That'd be great if you did it! |
Sure - I'll link it here when it's ready |
Ok build's passed so should be ready to go: #5891 |
As described in #5768, the current behaviour treats exports correctly if they are assigned a value normally, but incorrectly if they are assigned a value via destructuring.
This PR adds a failing test based on description in #5768, and updates to make the test pass.
The
isIdentifier
case is unchanged, I've just added new cases forObjectPattern
andArrayPattern
. There might be a more elegant way to frame this, so please suggest if you see one :)PS. first PR so please let me know if I missed any steps