Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section on troubleshooting [skip ci] #5788

Merged
merged 3 commits into from May 29, 2017
Merged

Add a section on troubleshooting [skip ci] #5788

merged 3 commits into from May 29, 2017

Conversation

peey
Copy link
Contributor

@peey peey commented May 28, 2017

Q A
License MIT
Doc PR yes

Add a troubleshooting section to CONTRIBUTING.md for common gotchas while developing on babel

@codecov
Copy link

codecov bot commented May 29, 2017

Codecov Report

Merging #5788 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5788      +/-   ##
==========================================
- Coverage   84.79%   84.76%   -0.04%     
==========================================
  Files         204      204              
  Lines        9607     9607              
  Branches     2701     2701              
==========================================
- Hits         8146     8143       -3     
- Misses        977      980       +3     
  Partials      484      484
Impacted Files Coverage Δ
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f3ab4...d6951fc. Read the comment docs.

CONTRIBUTING.md Outdated

In case you're locally getting errors which are not on the CI, it may be due to

- Updates in Dependencies: Make sure you run make bootstrap before you run `make build` or `make watch` before you run the tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make bootstrap

@hzoo hzoo added the PR: Docs 📝 A type of pull request used for our changelog categories label May 29, 2017
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, really appreciated!

@hzoo hzoo merged commit dcbb6c5 into babel:master May 29, 2017
@hzoo
Copy link
Member

hzoo commented May 29, 2017

Oh, merged to master

@peey
Copy link
Contributor Author

peey commented May 29, 2017

Oh, I accidentally made it to master. Maybe it's a github UI default. I cherry-picked all 3 commits and opened a new PR : #5790

Please merge that too @hzoo

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants