Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist toSequenceExpression's convert helper #5693

Merged
merged 4 commits into from May 19, 2017

Conversation

jridgewell
Copy link
Member

@jridgewell jridgewell commented May 3, 2017

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No?
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Lots
Fixed Tickets Fixes #5080, Fixes #4224
License MIT
Doc PR
Dependency Changes

Like it says. Also fixes two bugs when recursing into IfStatements or BlockStatements that themselves bail.

@mention-bot
Copy link

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @boopathi and @zertosh to be potential reviewers.

@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #5693 into master will increase coverage by 0.07%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5693      +/-   ##
=========================================
+ Coverage   84.72%   84.8%   +0.07%     
=========================================
  Files         204     204              
  Lines        9600    9603       +3     
  Branches     2697    2700       +3     
=========================================
+ Hits         8134    8144      +10     
+ Misses        978     975       -3     
+ Partials      488     484       -4
Impacted Files Coverage Δ
packages/babel-types/src/converters.js 94.55% <97.43%> (+3.58%) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/context.js 87.06% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412180e...8aee10c. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #5693 into master will increase coverage by 0.04%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5693      +/-   ##
==========================================
+ Coverage   84.72%   84.77%   +0.04%     
==========================================
  Files         204      204              
  Lines        9600     9603       +3     
  Branches     2697     2700       +3     
==========================================
+ Hits         8134     8141       +7     
  Misses        978      978              
+ Partials      488      484       -4
Impacted Files Coverage Δ
packages/babel-types/src/converters.js 94.55% <97.43%> (+3.58%) ⬆️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412180e...f265860. Read the comment docs.

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 19, 2017
@hzoo hzoo merged commit 5f866f2 into babel:master May 19, 2017
@hzoo
Copy link
Member

hzoo commented May 19, 2017

Oh dang this was on master haha..

@jridgewell
Copy link
Member Author

Whoops, I'll port it over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
3 participants