Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport doc changes #5613

Merged
merged 8 commits into from Apr 8, 2017
Merged

Backport doc changes #5613

merged 8 commits into from Apr 8, 2017

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Apr 8, 2017

Q A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets
License MIT
Doc PR yes
Dependency Changes

Includes changes from PR (also visible in commits):

Specific changes from Babel 7 were excluded. Once this is merged I will push it on the website.

@xtuc xtuc added the PR: Docs 📝 A type of pull request used for our changelog categories label Apr 8, 2017
@mention-bot
Copy link

@xtuc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @trodrigues to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 8, 2017

Codecov Report

Merging #5613 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
+ Coverage   84.45%   84.48%   +0.03%     
==========================================
  Files         204      204              
  Lines        9600     9600              
  Branches     2697     2697              
==========================================
+ Hits         8108     8111       +3     
+ Misses       1005     1002       -3     
  Partials      487      487
Impacted Files Coverage Δ
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/context.js 86.2% <0%> (+0.86%) ⬆️
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3a2c2...ca435b6. Read the comment docs.

Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@existentialism existentialism merged commit 11b7db0 into master Apr 8, 2017
@xtuc xtuc deleted the backport-doc-changes branch April 8, 2017 15:04
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants